Jason Fehr has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/23098 )
Change subject: IMPALA-13235: Add Reusable GFlag Validators ...................................................................... IMPALA-13235: Add Reusable GFlag Validators Adds three reusable GFlag validators in a header-only file. These validators can be passed directly to a GFlag DEFINE_validator() function. Sample usage: DEFINE_int32(myflag, 0, "Help text"); DEFINE_validator(myflag, ge_one) Workload management flags use a similar technique where a numeric validator is defined once and re-used throughout the flags. This validator has been moved to the new header-only file. Testing accomplished by the tests in gflag-validator-util-test.cc successfully passing locally and in a build. Change-Id: I752fd90ddfdad864d5d150a92495562d3d8ba0a2 --- M be/src/util/CMakeLists.txt A be/src/util/gflag-validator-util-test.cc A be/src/util/gflag-validator-util.h M be/src/workload_mgmt/workload-management-flags.cc 4 files changed, 221 insertions(+), 18 deletions(-) git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/23098/4 -- To view, visit http://gerrit.cloudera.org:8080/23098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: newpatchset Gerrit-Change-Id: I752fd90ddfdad864d5d150a92495562d3d8ba0a2 Gerrit-Change-Number: 23098 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
