Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23098 )
Change subject: IMPALA-13235: Add Reusable GFlag Validators ...................................................................... Patch Set 4: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/23098/3/be/src/util/gflag-validator-util-test.cc File be/src/util/gflag-validator-util-test.cc: http://gerrit.cloudera.org:8080/#/c/23098/3/be/src/util/gflag-validator-util-test.cc@112 PS3, Line 112: // > copy-paste error, fixed Still confused because there is no gt_one function exist. Do you meant to test gt_zero function in > 1 scenario? -- To view, visit http://gerrit.cloudera.org:8080/23098 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I752fd90ddfdad864d5d150a92495562d3d8ba0a2 Gerrit-Change-Number: 23098 Gerrit-PatchSet: 4 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 19:29:21 +0000 Gerrit-HasComments: Yes
