Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/23074 )
Change subject: IMPALA-13898: Incorporate partition information into tuple cache keys ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/23074/2/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/23074/2/be/src/exec/tuple-cache-node.cc@442 PS2, Line 442: uint32_t TupleCacheNode::HashHdfsPartitionDescriptor( > Should we have any tracing for this hashing like the Java-side hashing has? Filed IMPALA-14191 to track this. It should be doable. http://gerrit.cloudera.org:8080/#/c/23074/2/be/src/exec/tuple-cache-node.cc@499 PS2, Line 499: ExecNode > const Done http://gerrit.cloudera.org:8080/#/c/23074/2/be/src/runtime/descriptors.h File be/src/runtime/descriptors.h: http://gerrit.cloudera.org:8080/#/c/23074/2/be/src/runtime/descriptors.h@429 PS2, Line 429: uint32_t partition_key_expr_hash_; > consider moving adjacent to another 32-bit field to improve packing. I tried moving it around, but nothing impacted the size of the class. -- To view, visit http://gerrit.cloudera.org:8080/23074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7109fcf8a30bf915bb566f7d642f8037793a8c Gerrit-Change-Number: 23074 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 26 Jun 2025 23:24:18 +0000 Gerrit-HasComments: Yes
