Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23074 )
Change subject: IMPALA-13898: Incorporate partition information into tuple cache keys ...................................................................... Patch Set 6: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23074/6/be/src/exec/tuple-cache-node.cc File be/src/exec/tuple-cache-node.cc: http://gerrit.cloudera.org:8080/#/c/23074/6/be/src/exec/tuple-cache-node.cc@499 PS6, Line 499: for (const ExecNode* exec_node : scan_nodes) { This seems like it could be large enough we might want to construct a map for lookups. http://gerrit.cloudera.org:8080/#/c/23074/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/23074/6/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@2850 PS6, Line 2850: for (TScanRangeLocationList origLocList: orig.concrete_ranges) { I don't have a good intuition for how large this list can get. But this code is also not new. -- To view, visit http://gerrit.cloudera.org:8080/23074 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a7109fcf8a30bf915bb566f7d642f8037793a8c Gerrit-Change-Number: 23074 Gerrit-PatchSet: 6 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 07 Jul 2025 23:53:04 +0000 Gerrit-HasComments: Yes
