Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23074 )

Change subject: IMPALA-13898: Incorporate partition information into tuple 
cache keys
......................................................................


Patch Set 3:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python3 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with Python3's venv installed.

http://gerrit.cloudera.org:8080/#/c/23074/3/be/src/exec/tuple-cache-node.cc
File be/src/exec/tuple-cache-node.cc:

http://gerrit.cloudera.org:8080/#/c/23074/3/be/src/exec/tuple-cache-node.cc@501
PS3, Line 501:         const HdfsScanNodeBase* scan_node = static_cast<const 
HdfsScanNodeBase*>(exec_node);
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/23074
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3a7109fcf8a30bf915bb566f7d642f8037793a8c
Gerrit-Change-Number: 23074
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Thu, 26 Jun 2025 23:31:12 +0000
Gerrit-HasComments: Yes

Reply via email to