Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/22865 )
Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive JDBC tables ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/22865/7/fe/src/main/java/org/apache/impala/catalog/TableLoader.java File fe/src/main/java/org/apache/impala/catalog/TableLoader.java: http://gerrit.cloudera.org:8080/#/c/22865/7/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@240 PS7, Line 240: table != null if (!Strings.isNullOrEmpty(table)) { http://gerrit.cloudera.org:8080/#/c/22865/7/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@243 PS7, Line 243: if (query != null) { if (!Strings.isNullOrEmpty(query)) { http://gerrit.cloudera.org:8080/#/c/22865/7/fe/src/main/java/org/apache/impala/catalog/TableLoader.java@232 PS7, Line 232: String table = msTbl.getParameters().get("hive.sql.table"); : String query = msTbl.getParameters().get("hive.sql.query"); : : if (Strings.isNullOrEmpty(table) && Strings.isNullOrEmpty(query)) { : throw new TableLoadingException("Either 'hive.sql.table' or" + : " 'hive.sql.query' must be set."); : } : : if (table != null) { : impala_tbl_props.put("table", table); : } : if (query != null) { : impala_tbl_props.put("query", query); : } > @Wenzhe, do we give an error when both the properties are mentioned or shou No, if both properties are set, "query" has higher priority than "table" -- To view, visit http://gerrit.cloudera.org:8080/22865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b Gerrit-Change-Number: 22865 Gerrit-PatchSet: 8 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 01 Jul 2025 18:41:50 +0000 Gerrit-HasComments: Yes
