Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/22865 )
Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive JDBC tables ...................................................................... Patch Set 5: (4 comments) http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@308 PS5, Line 308: Ensure Check if 'table' property is not null and not empty http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@350 PS5, Line 350: int limit = -1; : if (params.isSetLimit()) limit = (int) params.getLimit(); : iterator_ = dbAccessor_.getRecordIterator(tableConfig_, limit, 0); : } else { : totalNumberOfRecords_ = dbAccessor_.getTotalNumberOfRecords(tableConfig_); indentation is off http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java: http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/conf/JdbcStorageConfigManager.java@27 PS5, Line 27: import org.apache.hadoop.hive.ql.metadata.Hive; Is this import needed? http://gerrit.cloudera.org:8080/#/c/22865/5/tests/custom_cluster/test_ext_data_sources.py File tests/custom_cluster/test_ext_data_sources.py: http://gerrit.cloudera.org:8080/#/c/22865/5/tests/custom_cluster/test_ext_data_sources.py@a290 PS5, Line 290: Don't remove this part when merging -- To view, visit http://gerrit.cloudera.org:8080/22865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b Gerrit-Change-Number: 22865 Gerrit-PatchSet: 5 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 16 Jun 2025 17:37:49 +0000 Gerrit-HasComments: Yes
