Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/22865 )
Change subject: IMPALA-13869: Support for 'hive.sql.query' property for Hive JDBC tables ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java File fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java: http://gerrit.cloudera.org:8080/#/c/22865/5/fe/src/main/java/org/apache/impala/extdatasource/jdbc/JdbcDataSource.java@316 PS5, Line 316: project = schema_.getCols().stream().map( : TColumnDesc::getName).map( : name -> columnMapping.getOrDefault(name, name)) : .collect(Collectors.joining(", ")); : } : sb.append(project); : sb.append(" FROM "); : : // Make jdbc table name to be quoted with double quotes if columnMapping is not empty : if (!columnMapping.isEmpty()) { : tableName = dbAccessor_.getCaseSensitiveName(tableName); : } : sb.append(tableName); : : String condition = QueryConditionUtil : .buildCondition(params.getPredicates(), columnMapping, dbAccessor_); : if (StringUtils.isNotBlank(condition)) { : sb.append(" WHERE ").append(condition); : } : : query = sb.toString(); indentation is off here. -- To view, visit http://gerrit.cloudera.org:8080/22865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I039fcc1e008233a3eeed8d09554195fdb8c8706b Gerrit-Change-Number: 22865 Gerrit-PatchSet: 5 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Mon, 16 Jun 2025 16:57:38 +0000 Gerrit-HasComments: Yes
