Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 8: (2 comments) http://gerrit.cloudera.org:8080/#/c/23094/8/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23094/8/tests/custom_cluster/test_admission_controller.py@2180 PS8, Line 2180: impalad_args="--vmodule admission-controller=3 --default_pool_max_requests=1 " Since this test asserting log content, please add disable_log_buffering=True parameter. http://gerrit.cloudera.org:8080/#/c/23094/8/tests/custom_cluster/test_admission_controller.py@2213 PS8, Line 2213: self.assert_log_contains(self.get_ac_log_name(), 'INFO', : "Coordinator not registered with the statestore", expected_count=0) Also verify that the query is rejected for the right reason in the log? I20250710 10:48:53.099134 3752091 admission-controller.cc:2599] Rejected, query id=e3483acc3722df4d:302f7d7100000000 reason: The coordinator no longer exists: rsuminto-22746:27000 -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 8 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 18:02:28 +0000 Gerrit-HasComments: Yes
