Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/23094/10/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23094/10/be/src/scheduling/cluster-membership-mgr.cc@205 PS10, Line 205: if (state->removed_coordinators_map.size() > MAX_REMOVED_COORD_SIZE) { : const string& oldest = state->removed_coordinators_order.front(); : state->removed_coordinators_map.erase(oldest); : state->removed_coordinators_order.pop_front(); > Eventually removed_coordinators_map will reach MAX_REMOVED_COORD_SIZE and s Thanks for the suggestion. Riza also mentioned a similar TTL-based approach. However, I think in some edge cases like IMPALA-10866, a coordinator may still send requests even after being dropped from the statestore, so we can't guarantee that a TTL would outlast such requests. To keep the design simple and predictable, this patch uses a fixed-size list as a bounded solution. We can consider making the size configurable or revisiting TTL logic if real issues arise, but so far, the MAX_REMOVED_COORD_SIZE (1000) list seems sufficient -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 10 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 10 Jul 2025 19:49:59 +0000 Gerrit-HasComments: Yes
