Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 14: (1 comment) http://gerrit.cloudera.org:8080/#/c/23094/13/be/src/scheduling/admissiond-env.cc File be/src/scheduling/admissiond-env.cc: http://gerrit.cloudera.org:8080/#/c/23094/13/be/src/scheduling/admissiond-env.cc@41 PS13, Line 41: > Instead of gt_zero, you can write custom validator for this flag that valid Done. Personally, I don’t think the cluster should fail to start if this config is out of range, the config is not critical, and we could just cap it to a reasonable value. But using a validator does keep the code cleaner, so it’s a good approach. Let’s keep test_retained_removed_coords_size to ensure the custom validator behaves as expected. -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 14 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 12 Jul 2025 22:39:46 +0000 Gerrit-HasComments: Yes
