Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 13: (2 comments) http://gerrit.cloudera.org:8080/#/c/23094/13/be/src/scheduling/admissiond-env.cc File be/src/scheduling/admissiond-env.cc: http://gerrit.cloudera.org:8080/#/c/23094/13/be/src/scheduling/admissiond-env.cc@41 PS13, Line 41: gt_zero Instead of gt_zero, you can write custom validator for this flag that validate both > 0 and <= 1000 bound. Thus, MAX_REMOVED_COORDINATOR_SIZE constant and test_retained_removed_coords_size is not needed because flag value is always valid. http://gerrit.cloudera.org:8080/#/c/23094/11/be/src/scheduling/cluster-membership-mgr.h File be/src/scheduling/cluster-membership-mgr.h: http://gerrit.cloudera.org:8080/#/c/23094/11/be/src/scheduling/cluster-membership-mgr.h@295 PS11, Line 295: members > Done Done -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 13 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 12 Jul 2025 22:07:12 +0000 Gerrit-HasComments: Yes
