Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23094 )
Change subject: IMPALA-12057: Track removed coordinators to reject queued queries early ...................................................................... Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/23094/11/be/src/scheduling/cluster-membership-mgr.cc File be/src/scheduling/cluster-membership-mgr.cc: http://gerrit.cloudera.org:8080/#/c/23094/11/be/src/scheduling/cluster-membership-mgr.cc@200 PS11, Line 200: t std::shared_ptr<ClusterMembershipMgr::Snapshot > The MAX_REMOVED_COORD_SIZE is to cap the maximum size to prevent any crazy Added a validator for FLAGS_cluster_membership_retained_removed_coords, and use MAX_REMOVED_COORD_SIZE only, init once at runtime by the min of FLAGS_cluster_membership_retained_removed_coords and 1000. -- To view, visit http://gerrit.cloudera.org:8080/23094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1e0f270299f8c20975d7895c17f4e2791c3360e0 Gerrit-Change-Number: 23094 Gerrit-PatchSet: 13 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 12 Jul 2025 22:01:11 +0000 Gerrit-HasComments: Yes
