Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23217 )
Change subject: IMPALA-10866: Add testcases for failures cases involving the admission service ...................................................................... Patch Set 1: (4 comments) http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@7 PS1, Line 7: failures nit: failure http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@11 PS1, Line 11: as nit: is http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@20 PS1, Line 20: behaves nit: behavior is http://gerrit.cloudera.org:8080/#/c/23217/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23217/1/tests/custom_cluster/test_admission_controller.py@2283 PS1, Line 2283: # The first query should be canceled after coord1 is killed, Do we return an error in this case to the client explaining why the query was cancelled? If not, we should probably capture the error message from log in the testcase. -- To view, visit http://gerrit.cloudera.org:8080/23217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If617326cbc6fe2567857d6323c6413d98c92d009 Gerrit-Change-Number: 23217 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Comment-Date: Thu, 31 Jul 2025 00:19:00 +0000 Gerrit-HasComments: Yes
