Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23217 )
Change subject: IMPALA-10866: Add testcases for failure cases involving the admission service ...................................................................... Patch Set 2: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2270 PS2, Line 2270: create_beeswax_client Nit: Beeswax is deprecated, use HS2 instead. http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2277 PS2, Line 2277: create_beeswax_client() Nit: Beeswax is deprecated, use HS2 instead. http://gerrit.cloudera.org:8080/#/c/23217/2/tests/custom_cluster/test_admission_controller.py@2292 PS2, Line 2292: coord1.start() Is there a need to restart the coordinator here or will the next test take care of restarting the entire mincluster? -- To view, visit http://gerrit.cloudera.org:8080/23217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If617326cbc6fe2567857d6323c6413d98c92d009 Gerrit-Change-Number: 23217 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jason Fehr <jf...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 31 Jul 2025 23:22:17 +0000 Gerrit-HasComments: Yes
