Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23217 )
Change subject: IMPALA-10866: Add testcases for failure cases involving the admission service ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@7 PS1, Line 7: failure > nit: failure Done http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@11 PS1, Line 11: is > nit: is Done http://gerrit.cloudera.org:8080/#/c/23217/1//COMMIT_MSG@20 PS1, Line 20: behavio > nit: behavior is Done http://gerrit.cloudera.org:8080/#/c/23217/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23217/1/tests/custom_cluster/test_admission_controller.py@2283 PS1, Line 2283: > Do we return an error in this case to the client explaining why the query w I think the client can't connect to coord1 after coord1 is down, so it wasn’t able to get anything from the profile. However, I saw in the admissiond logs that the query was released, so I added that as the detection for query1 -- To view, visit http://gerrit.cloudera.org:8080/23217 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If617326cbc6fe2567857d6323c6413d98c92d009 Gerrit-Change-Number: 23217 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <wydbaggio...@gmail.com> Gerrit-Reviewer: Abhishek Rawat <ara...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com> Gerrit-Comment-Date: Thu, 31 Jul 2025 04:08:41 +0000 Gerrit-HasComments: Yes
