Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/23257 )
Change subject: IMPALA-14276: Fix memory leak by removing AdmissionState on rejection ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/23257/3/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23257/3/be/src/scheduling/admission-control-service.cc@215 PS3, Line 215: if (admission_state->admission_done && !admission_state->admit_status.ok()) { : LOG(INFO) << "Query " << req->query_id() : << " was rejected. Removing admission state to free resources."; : discard_result(admission_state_map_.Delete(req->query_id())); : } > GetQueryStatus rpc could fail and is retriable so we should make this more Yeah, that’s a good point, retries after a failed rpc could hit an "invalid handle" if the admission state was already removed. I considered adding a delayed removal mechanism, but it feels like extra complexity for a case that’s rare and not too harmful. Clients hitting "invalid handle" for a retry seem okay as a terminal signal. Let me know if you think this case is common enough to justify the extra logic -- To view, visit http://gerrit.cloudera.org:8080/23257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fba4f176c648ed7811225f7f94c91342a724d10 Gerrit-Change-Number: 23257 Gerrit-PatchSet: 3 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 16:58:00 +0000 Gerrit-HasComments: Yes
