Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23257 )
Change subject: IMPALA-14276: Fix memory leak by removing AdmissionState on rejection ...................................................................... Patch Set 5: Code-Review+1 (2 comments) I have no further comment. http://gerrit.cloudera.org:8080/#/c/23257/5/be/src/scheduling/admission-control-service.cc File be/src/scheduling/admission-control-service.cc: http://gerrit.cloudera.org:8080/#/c/23257/5/be/src/scheduling/admission-control-service.cc@216 PS5, Line 216: LOG(INFO) << "Query " << req->query_id() : << " was rejected. Removing admission state to free resources."; nit: IMO, since you already LOG(INFO) here, might as well print state map size as well in single log line. http://gerrit.cloudera.org:8080/#/c/23257/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23257/4/tests/custom_cluster/test_admission_controller.py@2374 PS4, Line 2374: number_of_iterations = 500 > It is around 140s, now is increasing from around 100MB to 140MB with 1000 q Done -- To view, visit http://gerrit.cloudera.org:8080/23257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fba4f176c648ed7811225f7f94c91342a724d10 Gerrit-Change-Number: 23257 Gerrit-PatchSet: 5 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 21:36:19 +0000 Gerrit-HasComments: Yes
