Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/23257 )
Change subject: IMPALA-14276: Fix memory leak by removing AdmissionState on rejection ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/23257/4/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/23257/4/tests/custom_cluster/test_admission_controller.py@2389 PS4, Line 2389: # Check if the admission state map size stays 1. Why is the size 1 and not 0 if we're logging after deleting query_id from map? Is it because the GetQueryStatus request could come after the next query gets queued? You could also put a sleep after each iteration and check for size 0 instead? -- To view, visit http://gerrit.cloudera.org:8080/23257 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9fba4f176c648ed7811225f7f94c91342a724d10 Gerrit-Change-Number: 23257 Gerrit-PatchSet: 4 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 06 Aug 2025 20:16:51 +0000 Gerrit-HasComments: Yes
