Vuk Ercegovac has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 )
Change subject: IMPALA-7144: Re-enable TestDescribeTableResults ...................................................................... Patch Set 3: (5 comments) several small suggestions to make things clearer, then lgtm. http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1811 PS3, Line 1811: columns_ add a comment to clarify if these are column names or values. http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1812 PS3, Line 1812: location_; add a comment, e.g., "the value of the describe result's location field" http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1950 PS3, Line 1950: cleanup ws http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1961 PS3, Line 1961: [#col_name,data_type example makes it clearer. too not distract this method, pls minimize this a bit.. for example, its not needed to have so many column example (two #col_name makes sense to illustrate the repetition). the location field should stay. a few fields that are not needed is also fine, but would be good to remove the majority of these. http://gerrit.cloudera.org:8080/#/c/10643/3/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@2024 PS3, Line 2024: rowIdx moving this offset in a loop without a check is error prone. pls add a precondition before each rows access that rowIdx < rows.size() -- To view, visit http://gerrit.cloudera.org:8080/10643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Gerrit-Change-Number: 10643 Gerrit-PatchSet: 3 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 05:10:08 +0000 Gerrit-HasComments: Yes
