Fredy Wijaya has posted comments on this change. ( http://gerrit.cloudera.org:8080/10643 )
Change subject: IMPALA-7144: Re-enable TestDescribeTableResults ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/10643/5/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java File fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java: http://gerrit.cloudera.org:8080/#/c/10643/5/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1979 PS5, Line 1979: rowIdx += 2; // Skips over the first empty line. : Preconditions.checkElementIndex(rowIdx, rows.size()); > simplify: Done http://gerrit.cloudera.org:8080/#/c/10643/5/fe/src/test/java/org/apache/impala/analysis/AuthorizationTest.java@1985 PS5, Line 1985: rowIdx++; > simplify: Done -- To view, visit http://gerrit.cloudera.org:8080/10643 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3aeaecf5b6d906a66d338e165a6d506e3964563f Gerrit-Change-Number: 10643 Gerrit-PatchSet: 6 Gerrit-Owner: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Fredy Wijaya <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: Vuk Ercegovac <[email protected]> Gerrit-Comment-Date: Fri, 08 Jun 2018 16:04:26 +0000 Gerrit-HasComments: Yes
