Sailesh Mukil has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 )
Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling ...................................................................... Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/asan.h File be/src/util/asan.h: http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/asan.h@a32 PS6, Line 32: Could you add a comment to the commit message as to why you removed this? http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@96 PS6, Line 96: EVPCipherCtx We usually prepend the names of these kinds of classes/structs with 'scoped'. So renaming to ScopedEVPCipherCtx would be better. http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@97 PS6, Line 97: EVPCipherCtx(int padding) { Make 'explicit' to avoid implicit conversions. http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@171 PS6, Line 171: ctx.ctx nit: Maybe it would be cleaner to add a getter() to the newly added struct, to get the context? Your call though. -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 6 Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Comment-Date: Mon, 11 Jun 2018 18:37:10 +0000 Gerrit-HasComments: Yes
