Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10666 )
Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling ...................................................................... Patch Set 7: (4 comments) http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/asan.h File be/src/util/asan.h: http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/asan.h@a32 PS6, Line 32: > Could you add a comment to the commit message as to why you removed this? It's a dumb bug - clang 5.0 >= 3.7 but this expression returns false. http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc File be/src/util/openssl-util.cc: http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@96 PS6, Line 96: ScopedEVPCip > We usually prepend the names of these kinds of classes/structs with 'scoped Done http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@97 PS6, Line 97: explicit ScopedEVPCipherCtx(int padding) { > Make 'explicit' to avoid implicit conversions. Done http://gerrit.cloudera.org:8080/#/c/10666/6/be/src/util/openssl-util.cc@171 PS6, Line 171: ctx.ctx > nit: Maybe it would be cleaner to add a getter() to the newly added struct, I didn't want to overengineer it - the plain struct seemed simpler here. -- To view, visit http://gerrit.cloudera.org:8080/10666 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184 Gerrit-Change-Number: 10666 Gerrit-PatchSet: 7 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 12 Jun 2018 15:05:41 +0000 Gerrit-HasComments: Yes
