Sailesh Mukil has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/10666 )

Change subject: IMPALA-7145: fix leak of OpenSSL context when spilling
......................................................................


Patch Set 7: Code-Review+1

(1 comment)

One last comment. LGTM otherwise. Feel free to upgrade to a +2 if no one else 
is looking at this.

http://gerrit.cloudera.org:8080/#/c/10666/7/be/src/util/openssl-util.cc
File be/src/util/openssl-util.cc:

http://gerrit.cloudera.org:8080/#/c/10666/7/be/src/util/openssl-util.cc@103
PS7, Line 103:
DISALLOW_COPY_AND_ASSIGN(ScopedEVPCipherCtx);



--
To view, visit http://gerrit.cloudera.org:8080/10666
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I98760ed8f31b18b489a156f945c29c95c9bf3184
Gerrit-Change-Number: 10666
Gerrit-PatchSet: 7
Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com>
Gerrit-Comment-Date: Tue, 12 Jun 2018 15:53:15 +0000
Gerrit-HasComments: Yes

Reply via email to