Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 8: (1 comment) http://gerrit.cloudera.org:8080/#/c/23418/8/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23418/8/be/src/observe/otel.cc@306 PS8, Line 306: (VLOG_IS_ON(2)) > If otel log level can not change on the fly, then perhaps we should repurpo The SDK doesn't log INFO level messages in the trace code. It's all debug, warning, and error. For the debug logs, 8 log messages are generated per query totaling 9k bytes plus however many bytes are needed to represent the redacted query string (because the redacted query string itself is included in the SDK debug log). The first couple patchsets of this change used the otel_debug flag to set the SDK's log level to debug. I moved away from that implementation because I want debug logging to be an all-or-nothing thing. I don't want multiple flags to have to be set to enable all debug logging. Impala has these flags that enable debug logging, thus using the otel_debug flag to enable OTel SDK debug logging does have a precedent. -krb5_debug_file -- Turn on Kerberos debugging and output to this file -tuple_cache_debug_dump_dir -- Directory for dumping the intermediate query result tuples for debugging purpose. -non_impala_java_vlog -- The log level (equivalent to --v) for non-Impala Java classes After thinking about this design more, my preference is still to set the OTel SDK log level based on the glog level, but I am very much open to having a separate flag if it makes sense. The number of bytes logged by the OTel SDK in debug mode is fairly small compared to the number of bytes logged in debug mode. When I ran the query "select * from functional.alltypes where id=1" with glog level set to debug (iv=2), it generated 103k bytes of logs including the OTel SDK debug logs. -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 8 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 19 Sep 2025 15:26:13 +0000 Gerrit-HasComments: Yes
