Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 7: (3 comments) http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc File be/src/observe/otel-flags.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc@a29 PS4, Line 29: > Same here, since removing a flag breaks backwards compatibility. I'm ok wi Looked at the other flags. Did not find any that should be hidden but did find issues with the existing flags. Opened IMPALA-14455 to fix them. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@23 PS4, Line 23: #include <opentelemetry/common/attribute_value.h> > Isn't that reversed then? This would be the LIKELY branch. Good point, the debug logs generate more messages. In fact, I don't see anywhere in the trace portions of the OTel SDK that logs an info level message. They are all error, warn, or debug. http://gerrit.cloudera.org:8080/#/c/23418/6/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/6/be/src/observe/otel-log-handler.cc@71 PS6, Line 71: attr_stream.str()); > I'm not sure if this is faster. We could benchmark it. It's probably fine e Unless there is a significant performance concern, I want to keep the code this way because it's easier to read. I should note the number of log messages written by the SDK is very low. There are 0 info level messages (just errors if the happen) and 5 or so debug messages per query. -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 7 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 21:52:50 +0000 Gerrit-HasComments: Yes
