Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/23418 )
Change subject: IMPALA-14372: Output OpenTelemetry SDK Logs to Impala Logs ...................................................................... Patch Set 6: (5 comments) http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc File be/src/observe/otel-flags.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-flags.cc@a29 PS4, Line 29: > nit: I am usually cautious about removing existing flag. But since this one Same here, since removing a flag breaks backwards compatibility. I'm ok with removing this flag since the feature is considered tech preview, and this flag didn't do anything besides create a lot of extra generic log messages. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.h File be/src/observe/otel-log-handler.h: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.h@22 PS4, Line 22: // Custom log handler for OpenTelemetry SDK internal logs. > nit: some class comment will be nice. Done http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc File be/src/observe/otel-log-handler.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@23 PS4, Line 23: #include <opentelemetry/common/attribute_value.h> > Why is this unlikely? I used UNLIKELY here to optimize the most common code path that will be used in a production setup. Glog level will most likely not be set to greater than 1 whenever speed is priority. When the glog level is 2 or greater, performance probably won't matter. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel-log-handler.cc@27 PS4, Line 27: #include "common/compiler-util.h" > We don't need StringStreamPop here, a regular stringstream is sufficient. Switched to std::stringstream Dug into this, and found that Substitute() args can only be primitive types and char arrays. I changed the code to only use the std::stringstream for the attributes and to use Substitute() for the rest. http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc File be/src/observe/otel.cc: http://gerrit.cloudera.org:8080/#/c/23418/4/be/src/observe/otel.cc@303 PS4, Line 303: > Not via this, it would need to be implemented in webserver.cc. I think that Not, it won't change. Looked into adding because I want the OTel SDK logging level to match the overall logging level, but the OTel SDK does not fully support dynamically changing the log level. I opened https://github.com/open-telemetry/opentelemetry-cpp/issues/3647 to request this feature and IMPALA-14453 to implement once the feature is availably in the OTel SDK -- To view, visit http://gerrit.cloudera.org:8080/23418 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I41aba21f46233e6430eede9606be1e791071717a Gerrit-Change-Number: 23418 Gerrit-PatchSet: 6 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 18 Sep 2025 20:01:32 +0000 Gerrit-HasComments: Yes
