Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23519 )
Change subject: IMPALA-14452: Fix impala-shell SSL with Python 3.12 ...................................................................... Patch Set 1: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23519/1/shell/impala_shell/ImpalaHttpClient.py File shell/impala_shell/ImpalaHttpClient.py: http://gerrit.cloudera.org:8080/#/c/23519/1/shell/impala_shell/ImpalaHttpClient.py@75 PS1, Line 75: self.port = parsed.port or http_client.HTTPS_PORT : self.context = ssl_context Is it ok for ssl_context to be None? If not, an assert could check this http://gerrit.cloudera.org:8080/#/c/23519/1/shell/impala_shell/TSSLSocketWithFixes.py File shell/impala_shell/TSSLSocketWithFixes.py: http://gerrit.cloudera.org:8080/#/c/23519/1/shell/impala_shell/TSSLSocketWithFixes.py@32 PS1, Line 32: class TSSLSocketWithFixes(TSSLSocket): Can you add a link to the original TSSLSocket this matches with? https://github.com/apache/thrift/blob/0.16.0/lib/py/src/transport/TSSLSocket.py#L203 http://gerrit.cloudera.org:8080/#/c/23519/1/shell/impala_shell/TSSLSocketWithFixes.py@42 PS1, Line 42: host='localhost', : port=9090, : validate=True, : ca_certs=None, : unix_socket=None): I would remove the defaults that are not used in impala-shell -- To view, visit http://gerrit.cloudera.org:8080/23519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a9010ac4cb1f7d705935054b306cddaf8bdc7 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 13:44:07 +0000 Gerrit-HasComments: Yes
