Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23519 )
Change subject: IMPALA-14452: Fix impala-shell SSL with Python 3.12 ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/TSSLSocketWithFixes.py File shell/impala_shell/TSSLSocketWithFixes.py: http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/TSSLSocketWithFixes.py@1 PS9, Line 1: #!/usr/bin/env python : # > FYI: I had a separate change to remove this from TSSLSocketWithWildcardSAN. Done. http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/impala_client.py File shell/impala_shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/23519/9/shell/impala_shell/impala_client.py@496 PS9, Line 496: if self.use_ssl: : # TSSLSocket needs the ssl module, which may not be standard on all Operating : # Systems. Only attempt to import TSSLSocket if the user wants an SSL connection. : from impala_shell.TSSLSocketWithFixes import TSSLSocketWithFixes > Nit: Not your change, but this is probably obsolete and could move to the t Oh yeah, that's been safe for a long time now. Done. -- To view, visit http://gerrit.cloudera.org:8080/23519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a9010ac4cb1f7d705935054b306cddaf8bdc7 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 15 Oct 2025 20:08:36 +0000 Gerrit-HasComments: Yes
