Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/23519 )
Change subject: IMPALA-14452: Fix impala-shell SSL with Python 3.12 ...................................................................... Patch Set 10: Code-Review+2 (2 comments) The change looks good to me, but I would prefer running the tests in more environments. http://gerrit.cloudera.org:8080/#/c/23519/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23519/6//COMMIT_MSG@25 PS6, Line 25: Testing: Can you run the tests in a few more environments? Both older python and older openssl is interesting. I don't know what is the minimal expected Python / openssl version for impala-shell - for Impala server I think that we have some minimal expectations, but I don't know if force anything in the shell. http://gerrit.cloudera.org:8080/#/c/23519/6/tests/custom_cluster/test_client_ssl.py File tests/custom_cluster/test_client_ssl.py: http://gerrit.cloudera.org:8080/#/c/23519/6/tests/custom_cluster/test_client_ssl.py@236 PS6, Line 236: args = ["--ssl", "-q", "select 1 + 2", "-i", invalid_host, "--ca_cert=%s" % ca_cert] : run_impala_shell_cmd(vector, args, expect_success=False) : thanks for adding the negative tests! fyi there is one more similar test in test_ipv6 (but it is better to have it in test_client_ssl too): https://github.com/apache/impala/blob/f0a781806fa0bd2b2a4ab5af7f31f3bee4100654/tests/custom_cluster/test_ipv6.py#L216 -- To view, visit http://gerrit.cloudera.org:8080/23519 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I046a9010ac4cb1f7d705935054b306cddaf8bdc7 Gerrit-Change-Number: 23519 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 16 Oct 2025 09:33:14 +0000 Gerrit-HasComments: Yes
