Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23499 )

Change subject: IMPALA-14460: Implement connect_timeout_ms for HS2-HTTP
......................................................................


Patch Set 6:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py
File tests/shell/test_shell_commandline.py:

http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py@1413
PS5, Line 1413:     # used for the initial connection, subsequent setTimeout(0) 
sets socket to
> With setTimeout(0.0), the socket becomes non-blocking. For the initial conn
Updated this description.


http://gerrit.cloudera.org:8080/#/c/23499/5/tests/shell/test_shell_commandline.py@1432
PS5, Line 1432:                                   expect_success=False)
> I don't understand why sometimes OpenSession succeeds.
Did some Python 2 and 3 testing. I still need to try out the Dockerized 
environment, planning to let the test run do that for me.



--
To view, visit http://gerrit.cloudera.org:8080/23499
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9012066fb0d16497f309532021d7b323404b9fb2
Gerrit-Change-Number: 23499
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Comment-Date: Thu, 09 Oct 2025 23:57:53 +0000
Gerrit-HasComments: Yes

Reply via email to