Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23493 )
Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu ...................................................................... Patch Set 5: (5 comments) http://gerrit.cloudera.org:8080/#/c/23493/4/be/src/exec/kudu/kudu-scanner.cc File be/src/exec/kudu/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23493/4/be/src/exec/kudu/kudu-scanner.cc@469 PS4, Line 469: result.ptr = item_tuple_mem_pool->Allocate(total_tuple_byte_size); > Is the Kudu array mem layout different than our tuple layout? Is it not pos Sorry, I don't have an answer for this question. Maybe Xuebin can answer it once he returns, or we file a follow up JIRA to improve it? http://gerrit.cloudera.org:8080/#/c/23493/4/be/src/exec/kudu/kudu-scanner.cc@543 PS4, Line 543: // Evaluate the conjuncts that haven't been pushed down to Kudu. Conjunct evaluation > out of scope for this commit: Make sense. http://gerrit.cloudera.org:8080/#/c/23493/4/fe/src/main/java/org/apache/impala/util/KuduUtil.java File fe/src/main/java/org/apache/impala/util/KuduUtil.java: http://gerrit.cloudera.org:8080/#/c/23493/4/fe/src/main/java/org/apache/impala/util/KuduUtil.java@425 PS4, Line 425: } > nit: Can use @Nullable annotation here. Done http://gerrit.cloudera.org:8080/#/c/23493/4/fe/src/main/java/org/apache/impala/util/KuduUtil.java@461 PS4, Line 461: case NULL_TYPE: : case DATETIME: > nit: Method can use some documentation. Done http://gerrit.cloudera.org:8080/#/c/23493/4/fe/src/main/java/org/apache/impala/util/KuduUtil.java@486 PS4, Line 486: return ScalarType.createDecimalType( : typeAttributes.getPre > nit: Method can use some documentation. Done -- To view, visit http://gerrit.cloudera.org:8080/23493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310 Gerrit-Change-Number: 23493 Gerrit-PatchSet: 5 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Thu, 09 Oct 2025 01:45:37 +0000 Gerrit-HasComments: Yes
