Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23493 )
Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu ...................................................................... Patch Set 10: (1 comment) http://gerrit.cloudera.org:8080/#/c/23493/10/be/src/exec/kudu/kudu-scanner.cc File be/src/exec/kudu/kudu-scanner.cc: http://gerrit.cloudera.org:8080/#/c/23493/10/be/src/exec/kudu/kudu-scanner.cc@488 PS10, Line 488: slot->children_tuple_descriptor()->byte_size()) > Is there any types that are the same size between Impala and Kudu, i.e. kud One more observation: for Kudu STRING and BINARY arrays, memcpy-ing does simply copy Slice elements that are pointing to the actual memory containing binary data. With this, I guess Impala must be keeping Kudu's data around even after copying over those Slice elements for all the array elements to be able to access the underlying binary data, right? Unless I'm missing something here, then maybe it's not even necessary to copy the data over for elements of the same size, but just assign result.ptr to kudu_array_data? -- To view, visit http://gerrit.cloudera.org:8080/23493 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310 Gerrit-Change-Number: 23493 Gerrit-PatchSet: 10 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Chennaka <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Xuebin Su <[email protected]> Gerrit-Comment-Date: Tue, 21 Oct 2025 04:59:18 +0000 Gerrit-HasComments: Yes
