Alexey Serbin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23493 )

Change subject: IMPALA-14472: Add create/read support for ARRAY column of Kudu
......................................................................


Patch Set 10:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/23493/10//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23493/10//COMMIT_MSG@13
PS10, Line 13: Unlike rows, the elements of a Kudu array are stored in a 
different
             : format than Impala. Instead of per-row bit flag for NULL info, 
values
             : and NULL bits are stored in separate arrays.
> Thanks! My understanding is that the null bits for the tuple slots and the
I see -- now it makes more sense to me, thank you for the clarification.


http://gerrit.cloudera.org:8080/#/c/23493/10/tests/query_test/test_kudu.py
File tests/query_test/test_kudu.py:

http://gerrit.cloudera.org:8080/#/c/23493/10/tests/query_test/test_kudu.py@2013
PS10, Line 2013: UNNEST(array_{0})
> Thanks! I am thinking about how to support unnest() in the from clause.
Thank you for the clarification.

As I mentioned, I'm not expecting unnesting of a set of array columns to be 
implemented in this particular changelist, I was just curious if it's supported 
and suggested to add a test case if it would make sense.

If this type of queries are disallowed for Kudu arrays by the frontend as of 
now, enabling them might be a better fit for a separate venue, depending how 
much work is involved.  It's up to you, of course.  Just wanted to let you know 
this UNNEST test scenario looks good to me as-is as of PS11.



--
To view, visit http://gerrit.cloudera.org:8080/23493
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9282aac821bd30668189f84b2ed8fff7047e7310
Gerrit-Change-Number: 23493
Gerrit-PatchSet: 10
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Abhishek Chennaka <[email protected]>
Gerrit-Reviewer: Alexey Serbin <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Xuebin Su <[email protected]>
Gerrit-Comment-Date: Tue, 28 Oct 2025 18:56:34 +0000
Gerrit-HasComments: Yes

Reply via email to