Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23654 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/23654/3/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23654/3/common/thrift/Query.thrift@826 PS3, Line 826: ; nit: unnecessary semicolon. http://gerrit.cloudera.org:8080/#/c/23654/3/tests/custom_cluster/test_calcite_planner.py File tests/custom_cluster/test_calcite_planner.py: http://gerrit.cloudera.org:8080/#/c/23654/3/tests/custom_cluster/test_calcite_planner.py@46 PS3, Line 46: def test_calcite_fallback(self, vector, cursor): : # a select from a complex column will work for the 2 fallback options tested here. : vector.get_value('exec_option')['calcite_fallback'] = 'all_exceptions' : cursor.execute("select int_array_col from functional.allcomplextypes where 0 = 1;") : vector.get_value('exec_option')['calcite_fallback'] = 'unsupported_and_nonquery' : cursor.execute("select int_array_col from functional.allcomplextypes where 0 = 1;") This can be simplified into: def test_calcite_fallback(self): # a select from a complex column will work for the 2 fallback options tested here. options = {'calcite_fallback': 'all_exceptions'} self.execute_query("select int_array_col from functional.allcomplextypes where 0 = 1;", options) options = {'calcite_fallback': 'unsupported_and_nonquery'} self.execute_query("select int_array_col from functional.allcomplextypes where 0 = 1;", options) -- To view, visit http://gerrit.cloudera.org:8080/23654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6413b478fd11b645d05a60313990cb2b8c015a67 Gerrit-Change-Number: 23654 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 19:40:22 +0000 Gerrit-HasComments: Yes
