Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23654 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23654/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23654/5//COMMIT_MSG@20 PS5, Line 20: caughtand nit: caught and http://gerrit.cloudera.org:8080/#/c/23654/5/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23654/5/be/src/service/query-options.h@390 PS5, Line 390: ADVANCED Lets set this to DEVELOPMENT. http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift@157 PS5, Line 157: ALL_EXCEPTIONS = 0, : UNSUPPORTED_AND_NONQUERY = 1, : NONQUERY_ONLY = 2 Do you see if this enum will add new field? Would it make sense to just have INT value describing the fallback level, similar like EXPLAIN_LEVEL? Thus, CALCITE_FALLBACK_LEVEL=0 is all exceptions, CALCITE_FALLBACK_LEVEL=1 is all non-select and unsupported query, CALCITE_FALLBACK_LEVEL=2 is all non-select query only. -- To view, visit http://gerrit.cloudera.org:8080/23654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6413b478fd11b645d05a60313990cb2b8c015a67 Gerrit-Change-Number: 23654 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 22:27:10 +0000 Gerrit-HasComments: Yes
