Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23654 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 5: (3 comments) http://gerrit.cloudera.org:8080/#/c/23654/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23654/5//COMMIT_MSG@20 PS5, Line 20: caughtand > nit: caught and Done http://gerrit.cloudera.org:8080/#/c/23654/5/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/23654/5/be/src/service/query-options.h@390 PS5, Line 390: ADVANCED > Lets set this to DEVELOPMENT. Done http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift@157 PS5, Line 157: ALL_EXCEPTIONS = 0, : UNSUPPORTED_AND_NONQUERY = 1, : NONQUERY_ONLY = 2 > Do you see if this enum will add new field? Hmmm...I did think about it. I don't feel too strongly about this either way and I'm willing to change it, but I did it this way for 2 reasons 1) It is more explicit. 2) To answer your question...I'm not sure? There might be a need at some point to add another level that is in between all exceptions...like what if we did eventually try to support DDL? What if we have different "unsupported" levels? It's a bit of an unknown, and "all exceptions" will always be the least restrictive and "non-select query" will prolly always be the most restrictive. So I'd hate to have numbers in the middle. What do you think? -- To view, visit http://gerrit.cloudera.org:8080/23654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6413b478fd11b645d05a60313990cb2b8c015a67 Gerrit-Change-Number: 23654 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 10 Nov 2025 23:16:20 +0000 Gerrit-HasComments: Yes
