Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23654 )
Change subject: IMPALA-14488: Calcite planner: Support fallback to Original planner ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift File common/thrift/Query.thrift: http://gerrit.cloudera.org:8080/#/c/23654/5/common/thrift/Query.thrift@157 PS5, Line 157: ALL_EXCEPTIONS = 0, : UNSUPPORTED_AND_NONQUERY = 1, : NONQUERY_ONLY = 2 > Actually, EXPLAIN_LEVEL value is also thrift enum in Types.thrift. One last comment before I make a change... In the current way you mentioned it, there is a hierarchy. But one thing I was thinking about adding was an option where both UNSUPPORTED and PARSE exceptions are caught. Not sure it is needed, but at one point, I remember thinking about that. That would still be hierarchical, but now I have the create a 0.5. That's my only concern about having an enum. -- To view, visit http://gerrit.cloudera.org:8080/23654 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6413b478fd11b645d05a60313990cb2b8c015a67 Gerrit-Change-Number: 23654 Gerrit-PatchSet: 5 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Fri, 14 Nov 2025 17:27:55 +0000 Gerrit-HasComments: Yes
