Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23665 )
Change subject: IMPALA-14405 ADDENDUM: Catch exception for bad column names ...................................................................... Patch Set 3: Code-Review+1 (3 comments) http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG@24 PS1, Line 24: "select timestamp_col + interval 3 nanoseconds" > I agree we should add some tests. I don't mind if we don't test negative testcase now, at least until CalcitePlanner more functionally usable. We might still update Calcite version soon, and this minor problem may go away. http://gerrit.cloudera.org:8080/#/c/23665/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23665/1/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@187 PS1, Line 187: Error e) { > Done Done http://gerrit.cloudera.org:8080/#/c/23665/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23665/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@187 PS2, Line 187: Error > Can we go with a bit specific error type? and also maybe add a log in case It looks like we depends on Calcite behavior here. Current version does not support nanodecons and throw AssertionError. AssertionError is unchecked exception, and there might be other Error / RuntimeException can be thrown that we don't know yet. For the minor inconvenience of having weird column label, I don't mind leaving it as it (catch any Error). -- To view, visit http://gerrit.cloudera.org:8080/23665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c4d76a25fb2486eb1ef19485bce7888d45d282f Gerrit-Change-Number: 23665 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 15:29:37 +0000 Gerrit-HasComments: Yes
