Steve Carlin has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/23665 )

Change subject: IMPALA-14405 ADDENDUM: Catch exception for bad column names
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/23665/1//COMMIT_MSG@24
PS1, Line 24: "select timestamp_col + interval 3 nanoseconds"
> I don't mind if we don't test negative testcase now, at least until Calcite
It's actually not a Calcite error.  It's a MysqlDialect error.

I originally was using PostgreSQL dialect and that didn't have the problem, but 
changed it due to a code review comment.

If we came up with an Impala dialect, it might go away.  Or maybe revamp the 
whole way we do this.

In the meantime, I filed IMPALA-14561 to track this and I did put in a test 
case.



--
To view, visit http://gerrit.cloudera.org:8080/23665
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6c4d76a25fb2486eb1ef19485bce7888d45d282f
Gerrit-Change-Number: 23665
Gerrit-PatchSet: 1
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Pranav Lodha <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Steve Carlin <[email protected]>
Gerrit-Comment-Date: Tue, 18 Nov 2025 15:33:50 +0000
Gerrit-HasComments: Yes

Reply via email to