Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/23665 )
Change subject: IMPALA-14405 ADDENDUM: Catch exception for bad column names ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/23665/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java: http://gerrit.cloudera.org:8080/#/c/23665/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteRelNodeConverter.java@187 PS2, Line 187: Error > Can we go with a bit specific error type? and also maybe add a log in case Heh, I changed it to the more generic "Error" due to the previous code review comment. I think the more generic is better because I don't want a query to fail just because we missed a type of error when displaying a column header for impala-shell. Put in a logging message. I was unsure whether to do this but I guess if it's in "debug", it's ok and it won't add too much clutter to the logs, this should be rare. -- To view, visit http://gerrit.cloudera.org:8080/23665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6c4d76a25fb2486eb1ef19485bce7888d45d282f Gerrit-Change-Number: 23665 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 18 Nov 2025 15:32:14 +0000 Gerrit-HasComments: Yes
