Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7576 PS20, Line 7576: catalog_.addVersionsForInflightEvents(false, tbl, newCatalogVersion); > I think we should track them in partition level. If there are multiple part We can't track partitioned self-reload events because the API doesn't support it: https://github.infra.cloudera.com/CDH/Impala/blob/cdh_main/fe/src/compat-hive-3/java/org/apache/impala/compat/MetastoreShim.java#L557 We can only track them at table level currently. Also, I believe it is costly to modify reload event to accomodate Metastore instance of partition, just to track self-events. I think it is fine for now to identify them at table and in the edge-case we would have to reload the partitions twice. -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 21 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Wed, 19 Nov 2025 00:53:17 +0000 Gerrit-HasComments: Yes
