Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7576 PS20, Line 7576: catalog_.addVersionsForInflightEvents(false, tbl, newCatalogVersion); > To track self-events at partition-level, we first send self-events params i I'm still confused, as long as the parameters are carried in the RELOAD event, why we can't use them as partition-level parameters? We just use this map to extract the catalog service id and catalog version. https://github.com/apache/impala/blob/d8d44f3f147ce0f98bdd9e0387ae080010f55965/fe/src/main/java/org/apache/impala/catalog/events/SelfEventContext.java#L54 https://github.com/apache/impala/blob/d8d44f3f147ce0f98bdd9e0387ae080010f55965/fe/src/main/java/org/apache/impala/catalog/events/SelfEventContext.java#L84-L88 SelfEventContext(String dbName, String tblName, List<List<TPartitionKeyValue>> partitionKeyValues, Map<String, String> parameters) In the above constructor, we can get 'partitionKeyValues' from the partition object and use the table level 'parameters' that contains catalog service id and catalog version. Are we still missing something? -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 21 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 02 Dec 2025 03:20:05 +0000 Gerrit-HasComments: Yes
