Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: Fix wrong lastRefreshEventId set by firing RELOAD events ...................................................................... Patch Set 21: (1 comment) http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/20/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7576 PS20, Line 7576: catalog_.addVersionsForInflightEvents(false, tbl, newCatalogVersion); > We can't track partitioned self-reload events because the API doesn't suppo Though the function name is setTblParams(), we can use it as partition-level parameters. SelfEventContext() just extract the catalog version and catalog service id from it: https://github.com/apache/impala/blob/134c28d4451d648232e24789ac15e5ff9113ed75/fe/src/main/java/org/apache/impala/catalog/events/SelfEventContext.java#L84-L88 I think what we need to change are * addVersionsForInflightEvents() for the corresponding partitions for partition-level RELOAD events. * Use the partition-level constructor of SelfEventContext for partition-level RELOAD events in ReloadEvent#getSelfEventContext(): https://gerrit.cloudera.org/c/21665/21/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEvents.java#3441 https://github.com/apache/impala/blob/134c28d4451d648232e24789ac15e5ff9113ed75/fe/src/main/java/org/apache/impala/catalog/events/SelfEventContext.java#L53-L55 Another problem of tracking partition-level RELOAD event at table level InFlight list is that the list is pretty easy to get full. The max size is just 100: https://github.com/apache/impala/blob/134c28d4451d648232e24789ac15e5ff9113ed75/fe/src/main/java/org/apache/impala/catalog/events/InFlightEvents.java#L36 BTW, please use public links in upstream discussion. https://github.infra.cloudera.com/ is a private link. -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 21 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Thu, 20 Nov 2025 02:40:46 +0000 Gerrit-HasComments: Yes
