Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/planner/CTEScanNode.java File fe/src/main/java/org/apache/impala/planner/CTEScanNode.java: http://gerrit.cloudera.org:8080/#/c/22091/10/fe/src/main/java/org/apache/impala/planner/CTEScanNode.java@42 PS10, Line 42: public class CTEScanNode extends PlanNode { This name doesn't seem appropriate. It functions more like an exchange. So I'd like to revisit naming for a bunch of the new constructs in this patch. http://gerrit.cloudera.org:8080/#/c/22091/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaCTEConsumer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaCTEConsumer.java: http://gerrit.cloudera.org:8080/#/c/22091/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaCTEConsumer.java@36 PS10, Line 36: public class ImpalaCTEConsumer extends TableScan implements ImpalaPlanRel { I based this on a TableScan because I figured RelOptMaterialization in https://gerrit.cloudera.org/c/22091/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/service/CalciteOptimizer.java#447 expected one, but it seems to work with any RelNode. This functions more like a broadcast exchange, and would actually simplify the code to treat it as an Exchange or SingleRel. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 25 Nov 2025 21:00:06 +0000 Gerrit-HasComments: Yes
