Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 12: (1 comment) http://gerrit.cloudera.org:8080/#/c/22091/12/fe/src/main/java/org/apache/impala/planner/CTEBufferNode.java File fe/src/main/java/org/apache/impala/planner/CTEBufferNode.java: http://gerrit.cloudera.org:8080/#/c/22091/12/fe/src/main/java/org/apache/impala/planner/CTEBufferNode.java@52 PS12, Line 52: computeStats(analyzer); Based on PlanNode.init comments, I should probably move cardinality calculation to an overridden computeStats, and call super.init(analyzer) rather than manually setting outputSmap_. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 03 Dec 2025 04:47:30 +0000 Gerrit-HasComments: Yes
