Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/22091 )
Change subject: IMPALA-13531: Calcite CTE frontend ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/22091/10/be/src/service/frontend.cc File be/src/service/frontend.cc: http://gerrit.cloudera.org:8080/#/c/22091/10/be/src/service/frontend.cc@93 PS10, Line 93: DEFINE_string(cte_suggester_class, "org.apache.impala.calcite.cte.IdentitySuggester", > I hadn't thought of it, it does seem like it could be handled per-query. It I have no preference. Not sure what the "right" thing to do is, but I suppose a query option is more flexible, but not really sure the flexibility is needed. http://gerrit.cloudera.org:8080/#/c/22091/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/SuggesterFactory.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/SuggesterFactory.java: http://gerrit.cloudera.org:8080/#/c/22091/10/java/calcite-planner/src/main/java/org/apache/impala/calcite/cte/SuggesterFactory.java@27 PS10, Line 27: public static final String CTE_THRESHOLD = "impala.cte_threshold"; > It's used in CalciteOptimizer; probably doesn't make sense to declare it he Ah, I guess I missed it. I don't have a problem keeping the options together, that actually prolly makes more sense. -- To view, visit http://gerrit.cloudera.org:8080/22091 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id0840c0859d2fe25628d799a18d302cee1eb36e8 Gerrit-Change-Number: 22091 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Mon, 01 Dec 2025 17:29:17 +0000 Gerrit-HasComments: Yes
