Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 6: (3 comments) http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/6/be/src/exprs/geo/common.h@28 PS6, Line 28: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df669cbfaaf1edbfac0461acd1af45e12b81/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 > line too long (168 > 90) nit: Can shorten slightly to https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df6/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@74 PS6, Line 74: boolean addNatives = true; Is this mean to be a backend flag where you can switch on-off for experimentation? http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py@27 PS6, Line 27: super(TestGeospatialFuctions, cls).add_test_dimensions() : # Tests do not use tables at the moment, skip other fileformats than Parquet. Might add following as well. cls.ImpalaTestMatrix.add_dimension(create_single_exec_option_dimension()) -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 26 Nov 2025 18:28:19 +0000 Gerrit-HasComments: Yes
