Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 8: (6 comments) http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt File be/src/exprs/geo/CMakeLists.txt: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/CMakeLists.txt@29 PS8, Line 29: #add_library(ExprsGeo Why is this left in? http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/common.h File be/src/exprs/geo/common.h: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/common.h@28 PS8, Line 28: // see https://github.com/Esri/spatial-framework-for-hadoop/blob/7226df6/hive/src/main/java/com/esri/hadoop/hive/GeometryUtils.java#L21 It'd be nice to match a tagged version here if one makes sense. http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/geospatial-functions-ir.cc File be/src/exprs/geo/geospatial-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/geospatial-functions-ir.cc@104 PS8, Line 104: // https://github.com/apache/hive/blob/9eeab40173479c74b6fbf6657c3472b81ce4efcd/ql/src/java/org/apache/hadoop/hive/ql/udf/esri/ST_EnvIntersects.java#L63 > line too long (156 > 90) Could we refer to a tag for this as well? http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h File be/src/exprs/geo/shape-format.h: http://gerrit.cloudera.org:8080/#/c/23700/8/be/src/exprs/geo/shape-format.h@255 PS8, Line 255: // TODO: fix Z/M/ZM types and move to a function called from DCHECK Is this something you planned to do soon? http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/8/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@266 PS8, Line 266: LOG.error(ex.getMessage());; If this fails should we fallback to loading the Java types? Or fail startup? http://gerrit.cloudera.org:8080/#/c/23700/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test File testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test: http://gerrit.cloudera.org:8080/#/c/23700/8/testdata/workloads/functional-query/queries/QueryTest/geospatial-esri.test@2720 PS8, Line 2720: # TODO: move these new tests to geospatial-esri-extra? This doesn't seem hard to do. -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Dec 2025 22:30:55 +0000 Gerrit-HasComments: Yes
