Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/23700 )
Change subject: IMPALA-14573: port critical geospatial functions to c++ (part 1) ...................................................................... Patch Set 8: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java File fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java: http://gerrit.cloudera.org:8080/#/c/23700/6/fe/src/compat-hive-3/java/org/apache/impala/compat/HiveEsriGeospatialBuiltins.java@74 PS6, Line 74: boolean addNatives = true; > yes, see https://gerrit.cloudera.org/#/c/20602/6/be/src/common/global-flags Ack http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py File tests/query_test/test_geospatial_functions.py: http://gerrit.cloudera.org:8080/#/c/23700/6/tests/query_test/test_geospatial_functions.py@27 PS6, Line 27: def add_test_dimensions(cls): : super(TestGeospatialFuctions, cls).add_test_dimensions() > Done Done -- To view, visit http://gerrit.cloudera.org:8080/23700 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0ff950a25320549290a83a3b1c31ce828dd68e3c Gerrit-Change-Number: 23700 Gerrit-PatchSet: 8 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Vanko <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 04 Dec 2025 19:23:28 +0000 Gerrit-HasComments: Yes
